mirror of
https://github.com/maciejpedzich/playlist-entry-validator.git
synced 2024-11-28 00:15:48 +01:00
Minor refactor and success message rewording
This commit is contained in:
parent
724a52a28e
commit
da5b67a642
16
bot.ts
16
bot.ts
@ -28,23 +28,19 @@ const bot: ApplicationFunction = (app) => {
|
||||
event: 'REQUEST_CHANGES' | 'COMMENT'
|
||||
) => {
|
||||
if (review_id) {
|
||||
const { data } = await context.octokit.pulls.updateReview({
|
||||
await context.octokit.pulls.updateReview({
|
||||
...workingRepo,
|
||||
pull_number,
|
||||
review_id,
|
||||
body
|
||||
});
|
||||
|
||||
return data.id;
|
||||
} else {
|
||||
const { data } = await context.octokit.pulls.createReview({
|
||||
await context.octokit.pulls.createReview({
|
||||
...workingRepo,
|
||||
pull_number,
|
||||
event,
|
||||
body
|
||||
});
|
||||
|
||||
return data.id;
|
||||
}
|
||||
};
|
||||
|
||||
@ -73,6 +69,7 @@ const bot: ApplicationFunction = (app) => {
|
||||
|
||||
const spotifyResponse = await fetch(url);
|
||||
const found = spotifyResponse.status === 200;
|
||||
|
||||
let info: string | null = null;
|
||||
|
||||
if (found) {
|
||||
@ -112,12 +109,11 @@ const bot: ApplicationFunction = (app) => {
|
||||
});
|
||||
|
||||
const [existingReview] = priorReviews;
|
||||
const canMergeMessage = `🎉 @${workingRepo.owner} can merge your pull request! 🎉`;
|
||||
|
||||
let identifiedPlaylistsText = '';
|
||||
let renameRequiredText = '';
|
||||
let notFoundText = '';
|
||||
let successText = canMergeMessage;
|
||||
let successText = `🎉 @${workingRepo.owner} can merge your pull request! 🎉`;
|
||||
let reviewEvent: 'REQUEST_CHANGES' | 'COMMENT' = 'COMMENT';
|
||||
|
||||
if (validEntries.length > 0) {
|
||||
@ -173,7 +169,7 @@ const bot: ApplicationFunction = (app) => {
|
||||
...workingRepo,
|
||||
pull_number,
|
||||
review_id: existingReview.id,
|
||||
message: 'All new entries are now valid!'
|
||||
message: 'All new entries can be accepted!'
|
||||
});
|
||||
}
|
||||
} catch (error) {
|
||||
@ -183,7 +179,7 @@ const bot: ApplicationFunction = (app) => {
|
||||
...workingRepo,
|
||||
pull_number,
|
||||
event: 'COMMENT',
|
||||
body: `Something went wrong while verifying new entries! @${workingRepo.owner} should handle it shortly...`
|
||||
body: `Something went wrong while validating new entries! @${workingRepo.owner} should handle it shortly...`
|
||||
});
|
||||
}
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user