maciejpedzich/playlist-entry-validator
1
0
Fork 0
mirror of https://github.com/maciejpedzich/playlist-entry-validator.git synced 2024-09-19 18:46:21 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

Reword validation result messages

Browse Source
This commit is contained in:
Maciej Pędzich 2022-12-23 14:46:07 +01:00
parent eae9b4a347
commit b79596acef
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
bot.ts
View File

@ -34,7 +34,6 @@ const bot: ApplicationFunction = (app) => {
...workingRepo, ...workingRepo,
pull_number, pull_number,
review_id, review_id,
event,
body body
}); });
} else { } else {
@ -48,12 +47,12 @@ const bot: ApplicationFunction = (app) => {
}; };
try { try {
const allowlistedRepo = repoAllowlist.find( const isAllowlistedRepo = repoAllowlist.find(
({ owner, repo }) => ({ owner, repo }) =>
workingRepo.owner === owner && workingRepo.repo === repo workingRepo.owner === owner && workingRepo.repo === repo
); );
if (!allowlistedRepo) return; if (!isAllowlistedRepo) return;
const { data: prFiles } = await context.octokit.pulls.listFiles({ const { data: prFiles } = await context.octokit.pulls.listFiles({
...workingRepo, ...workingRepo,
@ -65,14 +64,22 @@ const bot: ApplicationFunction = (app) => {
status === 'added' && filename.startsWith(registryDirectoryPath) status === 'added' && filename.startsWith(registryDirectoryPath)
); );
if (filesToVerify.length === 0) return;
const playlistLookupResults = await Promise.all( const playlistLookupResults = await Promise.all(
filesToVerify.map(async ({ filename }) => { filesToVerify.map(async ({ filename }) => {
const filenameWithoutPath = removePathFromFilename(filename); const filenameWithoutPath = removePathFromFilename(filename);
const url = `https://open.spotify.com/playlist/${filenameWithoutPath}`; const url = `https://open.spotify.com/playlist/${filenameWithoutPath}`;
const expectedStatusCodes = [200, 404];
const spotifyResponse = await fetch(url); const spotifyResponse = await fetch(url);
const found = spotifyResponse.status === 200;
if (!expectedStatusCodes.includes(spotifyResponse.status))
throw new Error(
`${spotifyResponse.url} responded with code ${spotifyResponse.status}`
);
const found = spotifyResponse.status === 200;
let info: string | null = null; let info: string | null = null;
if (found) { if (found) {
@ -124,7 +131,7 @@ const bot: ApplicationFunction = (app) => {
.map(({ url, info }) => `- [${info}](${url})`) .map(({ url, info }) => `- [${info}](${url})`)
.join('\n'); .join('\n');
identifiedPlaylistsText = `### ✅ These playlists were indentified:\n${playlistLinks}`; identifiedPlaylistsText = `### ✅ These playlists have been indentified:\n${playlistLinks}`;
} }
if (notFoundPlaylists.length > 0) { if (notFoundPlaylists.length > 0) {
@ -134,7 +141,7 @@ const bot: ApplicationFunction = (app) => {
successText = ''; successText = '';
reviewEvent = 'REQUEST_CHANGES'; reviewEvent = 'REQUEST_CHANGES';
notFoundText = `### ❌ Playlists for these entries were not found:\n${renameList}`; notFoundText = `### ❌ Playlists for these entries don't exist:\n${renameList}`;
} }
if (entriesWithSiQuery.length > 0) { if (entriesWithSiQuery.length > 0) {